-
-
Notifications
You must be signed in to change notification settings - Fork 8
Refactor history messages merging logic #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the logic for merging system and regular messages in ToolUseAgent and MemoryManager by using unified methods. This improves code readability and reduces redundancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the merging of system and regular messages by centralizing the logic into a single method.
- Simplify merging in
MemoryManager::getProcessedMessages()
usingarray_merge
- Update
ToolUseAgent::call()
to use the newgetProcessedMessages()
method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/Memory/MemoryManager.php | Replaced conditional merge of last system message with direct array_merge |
src/Agent/Tool/ToolUseAgent.php | Swapped manual merge of messages for a call to getProcessedMessages() |
Comments suppressed due to low confidence (2)
src/Memory/MemoryManager.php:113
- [nitpick] Consider adding unit tests for
getProcessedMessages
to verify correct behavior when there are no system messages, a single system message, and multiple system messages to catch any unintended regressions.
$allMessages = array_merge($this->getSystemMessages(), $this->getMessages());
src/Memory/MemoryManager.php:113
- This replaces the previous behavior of merging only the last system message; now all system messages are included. Confirm whether you intended to include the full history or keep only the most recent system message, and adjust the logic if needed.
$allMessages = array_merge($this->getSystemMessages(), $this->getMessages());
lihq1403
reviewed
May 29, 2025
lihq1403
reviewed
May 29, 2025
This reverts commit df02d2e.
Updated the logic for merging system messages and regular messages in ToolUseAgent and MemoryManager to include all system messages instead of only the last one. This ensures proper handling of system messages in both classes.
huangdijia
commented
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the logic for merging system and regular messages in ToolUseAgent and MemoryManager by using unified methods. This improves code readability and reduces redundancy.
#11