Skip to content

Refactor history messages merging logic #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2025

Conversation

huangdijia
Copy link
Member

@huangdijia huangdijia commented May 29, 2025

Simplified the logic for merging system and regular messages in ToolUseAgent and MemoryManager by using unified methods. This improves code readability and reduces redundancy.

#11

Simplified the logic for merging system and regular messages in ToolUseAgent and MemoryManager by using unified methods. This improves code readability and reduces redundancy.
@huangdijia huangdijia requested a review from Copilot May 29, 2025 06:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the merging of system and regular messages by centralizing the logic into a single method.

  • Simplify merging in MemoryManager::getProcessedMessages() using array_merge
  • Update ToolUseAgent::call() to use the new getProcessedMessages() method

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Memory/MemoryManager.php Replaced conditional merge of last system message with direct array_merge
src/Agent/Tool/ToolUseAgent.php Swapped manual merge of messages for a call to getProcessedMessages()
Comments suppressed due to low confidence (2)

src/Memory/MemoryManager.php:113

  • [nitpick] Consider adding unit tests for getProcessedMessages to verify correct behavior when there are no system messages, a single system message, and multiple system messages to catch any unintended regressions.
$allMessages = array_merge($this->getSystemMessages(), $this->getMessages());

src/Memory/MemoryManager.php:113

  • This replaces the previous behavior of merging only the last system message; now all system messages are included. Confirm whether you intended to include the full history or keep only the most recent system message, and adjust the logic if needed.
$allMessages = array_merge($this->getSystemMessages(), $this->getMessages());

Updated the logic for merging system messages and regular messages in ToolUseAgent and MemoryManager to include all system messages instead of only the last one. This ensures proper handling of system messages in both classes.
@huangdijia huangdijia requested a review from lihq1403 May 29, 2025 07:07
@huangdijia huangdijia changed the title Refactor message merging logic Refactor history messages merging logic May 29, 2025
@huangzhhui huangzhhui merged commit 100525c into hyperf:master Jun 13, 2025
0 of 6 checks passed
@huangdijia huangdijia deleted the patch-1 branch June 13, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants