Add a test to demonstrate connection logical deadlock under high concurrency #852
Conversation
…equests than max_concurrent_streams
|
Thanks for providing a test case! What you describe in the issue sounds plausible, but I notice in this that flow control isn't touched, so neither side will give any more connection window space at all, so it will by design definitely not be able to make further progress. |
tests/h2-tests/tests/deadlock.rs
Outdated
| ); | ||
| } | ||
|
|
||
| thread::sleep(CHECK_FOR_PROGRESS_INTERVAL); |
There was a problem hiding this comment.
You'd also want to use something like tokio::time::sleep(CHECK_FOR_PROGRESS_INTERVAL).await to not block any of the other tasks on this thread.
It is not clear what you mean by this. Why would flow control need to be touched? The connection has a non-zero window (before it gets allocated to pending_open requests that could not possibly use it, based on the theory above), so all the requests should be transmitted through that window. Am I misunderstanding something? |
Test to accompany bug report #853.