Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose setting to disable grease #205

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Expose setting to disable grease #205

merged 1 commit into from
Jul 14, 2023

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jul 14, 2023 •
edited
Loading

This exposes a method on h3::client::Builder to disable grease.

I copied the documentation from Config::send_grease. Let me know if you want me to add anything else to it.

Ruben2424
Ruben2424 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Ruben2424 Ruben2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Ruben2424 Ruben2424 merged commit dccb3cd into hyperium:master Jul 14, 2023
@daxpedda
Copy link
Contributor Author

@Ruben2424 would it be possible to backport this to v0.3?
Which would be required to get https://github.com/bluejekyll/trust-dns/pull/1987 working for Cloudflare, until we find the bug (I'm still in the process of writing up an issue).

@daxpedda daxpedda mentioned this pull request Jul 14, 2023
Open
@daxpedda
Copy link
Contributor Author

See #206.

@daxpedda daxpedda mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben2424 Ruben2424 Ruben2424 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daxpedda @Ruben2424