chore: Move codegen to separate crate #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
move-codegen-to-separate-crate
branch
from
aacf071
to
d3a732a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Compilation fails before code generation in bootstrap tests if there is no code to include during development. Or, by the other any reason, when compilation fails because of the generated code, there are same cases as well. In these case, it is necessary to temporarily disable
includein the code by commenting out, etc., run bootstrap test, and then re-enableincludeagain, which feels troublesome.Separating code generation into a independent crate solves this problem. In addition, since it is possible to check that the generated code is updated with a simple command, the program can be easier by separating it from the code generation process.
Solution
Adds a
codegencrate, which is responsible for code generation, and moves out the change detection in generated code to the external process.