chore(transport): Replace axum with matchit#1561
Closed
tottoto wants to merge 1 commit intohyperium:masterfrom
Closed
chore(transport): Replace axum with matchit#1561tottoto wants to merge 1 commit intohyperium:masterfrom
tottoto wants to merge 1 commit intohyperium:masterfrom
Conversation
ea7f8ac to
303a4d7
Compare
Member
|
So I've actually been using the axum support a lot https://github.com/tursodatabase/libsql/blob/main/libsql-server/src/http/user/mod.rs#L417 for example there. So I think we if we move to matchit we loose this ability to mix and match? |
303a4d7 to
164282d
Compare
Collaborator
Author
|
I think so. |
Member
Yeah then lets keep it how it is for now. its quite useful to use the axum router actually ive found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Simplifies dependency tree, and implementations.
axumseems to be a relatively too large library for the purpose of implementingtonic's router. Directly usingmatchit, which is a crate used inaxumseems to be simple fortonic.Solution
Replaces
axumwithmatchitto implement the router.