Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Start development of version 0.13 #2014

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Oct 17, 2024

Motivation

Starts the development of version 0.13. This is needed to tell cargo-semver-checks that the development includes breaking changes.

Solution

Updates versions to 0.13.0-dev.

@tottoto tottoto force-pushed the start-development-of-version-0.13 branch from 88de84d to e4d4840 Compare October 17, 2024 21:54
@tottoto
Copy link
Collaborator Author

tottoto commented Oct 17, 2024

I opened this pull request as I think we probably could start development of the next version including breaking changes as @LucioFranco merged #1892 which includes breaking changes. This change is needed for the pull requests such as #2006 and #2013.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just want to change the version to not include dev, thanks.

edition = "2021"
homepage = "https://github.com/hyperium/tonic"
keywords = ["rpc", "grpc", "async", "codegen", "protobuf"]
license = "MIT"
name = "tonic-build"
readme = "README.md"
repository = "https://github.com/hyperium/tonic"
version = "0.12.3"
version = "0.13.0-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just make the version 0.13.0 and not add the dev portion?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 0.13.0.

@tottoto tottoto force-pushed the start-development-of-version-0.13 branch from e4d4840 to c147b85 Compare October 18, 2024 21:13
@tottoto tottoto force-pushed the start-development-of-version-0.13 branch from c147b85 to 274cde8 Compare October 18, 2024 21:13
@tobz tobz added this pull request to the merge queue Oct 22, 2024
Merged via the queue into hyperium:master with commit 3009cf5 Oct 22, 2024
17 checks passed
@tottoto tottoto deleted the start-development-of-version-0.13 branch October 22, 2024 21:17
shikhar added a commit to shikhar/tonic that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants