Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deflate compression support #2117

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

a1ien
Copy link
Contributor

@a1ien a1ien commented Jan 3, 2025

Motivation

See #2116

Solution

Add support for deflate compression

@a1ien a1ien force-pushed the add_support_for_deflate branch from a8ddaf7 to 2c75a6a Compare January 3, 2025 15:50
@tottoto
Copy link
Collaborator

tottoto commented Jan 4, 2025

The deflate compression in gRPC means the zlib format with the deflate algorithm.

gRPC Compression - Deflate Compression

@a1ien
Copy link
Contributor Author

a1ien commented Jan 4, 2025

Oh.. Yeah true. I will replace DeflateEncoder/DeflateDecoder with ZlibEncoder/ZlibDecoder.
Are there any other objections/suggestions?

@tottoto
Copy link
Collaborator

tottoto commented Jan 4, 2025

The test located at tests/compression need to be updated.

@a1ien a1ien force-pushed the add_support_for_deflate branch from 2c75a6a to 5447542 Compare January 7, 2025 09:46
@a1ien
Copy link
Contributor Author

a1ien commented Jan 7, 2025

Changed to Zlib and update tests.
Also tested with modified examples/src/compression/client.rs and python server from
https://github.com/grpc/grpc/tree/master/examples/python/compression with enabled deflate
python3 server.py --server_compression deflate
Work as expected

@a1ien a1ien force-pushed the add_support_for_deflate branch from 5447542 to 3b10680 Compare January 7, 2025 11:41
@tottoto tottoto enabled auto-merge January 7, 2025 12:39
@tottoto tottoto added this pull request to the merge queue Jan 7, 2025
Merged via the queue into hyperium:master with commit 79a06cc Jan 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants