feat(fees): Add fee receiver #5333
Conversation
Signed-off-by: Lohachov Mykhailo <[email protected]>
aoyako
requested review from
s8sato,
mversic,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
| pub asset: AssetDefinitionId, | ||
| } | ||
|
|
||
| impl Default for FeesOptions { |
There was a problem hiding this comment.
I don't think that we can have this default. You should find a different approach IMO
There was a problem hiding this comment.
Changed so they are obtained from the environment variables.
There was a problem hiding this comment.
Does it matter if the environment variable FEES_ASSET differs from peer to peer?
There was a problem hiding this comment.
This envis used only when building the executor and is the uploader's responsibility. It shouldn't be affected by individual peers' configurations.
There was a problem hiding this comment.
Well I'll be damned. This is not a bad solution at all
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
There was a problem hiding this comment.
I don't understand the question here. How would you do it otherwise? It's an executor that controls fees. Every tx will run through it and it will produce a fee deduction
There was a problem hiding this comment.
As mentioned in #5315 (comment), I now support using an executor and am questioning the necessity of customizing permission validations.
Would it not be sufficient to simply withhold permissions for modifying specific parameters, domains, accounts, and asset definitions?
| pub asset: AssetDefinitionId, | ||
| } | ||
|
|
||
| impl Default for FeesOptions { |
There was a problem hiding this comment.
Does it matter if the environment variable FEES_ASSET differs from peer to peer?
There was a problem hiding this comment.
I don't understand the question here. How would you do it otherwise? It's an executor that controls fees. Every tx will run through it and it will produce a fee deduction
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
github-actions
bot
added
the
config-changes
Signed-off-by: Lohachov Mykhailo <[email protected]>
Signed-off-by: Lohachov Mykhailo <[email protected]>
| // client.submit_all_blocking(upgrade_executor_isi(executor))?; | ||
| for isi in upgrade_executor_isi(executor) { | ||
| client.submit_blocking(isi)?; |
There was a problem hiding this comment.
I don't know for now why in the submit_all case, the executor complains about a lack of fuel.
Signed-off-by: Lohachov Mykhailo <[email protected]>
Adds fee receiver options. New functionality can be access by upgrading the executor to
fees_executor(See example in tests).Fees are read-only at this moment.
Default fees options are obtained from the environment variables and can be changed when building the executor.
Some missing features (will be added in this PR):