Add multi-sig example binaries #144

nicolad · 2025-09-18T09:18:51Z

Related to: #143

convert_to_multi_sig_user: Convert user to multi-sig with authorized users and threshold
multi_sig_order: Execute multi-sig orders with JSON and typed actions
multi_sig_register_token: Multi-sig token registration with spot deploy
multi_sig_usd_send: Multi-sig USD transfers with signature chain parameters

nicolad · 2025-09-18T09:38:42Z

@lmlmt note that multi-sig conversion isn’t implemented in the Rust SDK yet; the examples in this PR are scaffolding to show the shape/params. Once this PR is merged, I can look into adding the actual conversion support (or exposing a minimal API surface) and follow up with a dedicated PR

lmlmt · 2025-10-21T00:47:45Z

@lmlmt note that multi-sig conversion isn’t implemented in the Rust SDK yet; the examples in this PR are scaffolding to show the shape/params. Once this PR is merged, I can look into adding the actual conversion support (or exposing a minimal API surface) and follow up with a dedicated PR

@nicolad prefer having the multi-sig functionality implemented as well, for completeness

nicolad · 2025-10-21T10:00:26Z

@lmlmt note that multi-sig conversion isn’t implemented in the Rust SDK yet; the examples in this PR are scaffolding to show the shape/params. Once this PR is merged, I can look into adding the actual conversion support (or exposing a minimal API surface) and follow up with a dedicated PR

@nicolad prefer having the multi-sig functionality implemented as well, for completeness

thank you @lmlmt
will add today

- convert_to_multi_sig_user: Convert user to multi-sig with authorized users and threshold - multi_sig_order: Execute multi-sig orders with JSON and typed actions - multi_sig_register_token: Multi-sig token registration with spot deploy - multi_sig_usd_send: Multi-sig USD transfers with signature chain parameters Examples show structure for future implementation when multi-sig functionality is added to Rust SDK

…unt conversion, address management, and transaction operations for orders, USDC transfers, and spot transfers including comprehensive tests and examples.

luca992

I need multi-sign support so I was going over this pr, but I think the final payload is incorrect.

luca992 · 2025-11-08T09:42:42Z

src/exchange/exchange_client.rs

+    async fn post_multi_sig(
+        &self,
+        action: serde_json::Value,
+        signatures: Vec<Signature>,
+        nonce: u64,
+    ) -> Result<ExchangeResponseStatus> {
+        let exchange_payload = MultiSigExchangePayload {
+            action,
+            signatures,
+            nonce,
+            vault_address: self.vault_address,
+        };
+        let res = serde_json::to_string(&exchange_payload)
+            .map_err(|e| Error::JsonParse(e.to_string()))?;
+        debug!("Sending multi-sig request {res:?}");
+
+        let output = &self
+            .http_client
+            .post("/exchange", res)
+            .await
+            .map_err(|e| Error::JsonParse(e.to_string()))?;
+        debug!("Response: {output}");
+        serde_json::from_str(output).map_err(|e| Error::JsonParse(e.to_string()))
+    }


I don't think you are creating this correctly @nicolad

https://github.com/hyperliquid-dex/hyperliquid-python-sdk/blob/8baad667965968a020a2bb90d0287df0922ca941/hyperliquid/exchange.py#L1068-L1093

Thanks, appreciate the reference, will adjust.

Please have another look, adjusted.

@nicolad I'll actually try it, but looks like it will work if you have access to all the signers which is fine in my case. But this isn't something you can assume in most multisig cases. I think you'd want the function to take Signatures and not PrivateKeySigners? Also might need a way to export a signature. I'd think the usual flow is you collect signatures from the other wallets and when you have enough you as the submitter add your last signature and attach all the other signatures you collected.

This is what the python sdk above appears to do.

pub async fn multi_sig_usdc_transfer( &self, multi_sig_user: Address, amount: &str, destination: &str, wallets: &[PrivateKeySigner], )

Done, thank you.

luca992 · 2025-11-10T10:42:43Z

src/exchange/actions.rs

+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub payload_multi_sig_user: Option<String>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub outer_signer: Option<String>,


These shouldn't be here. The hyperliquid api returns a deserializaiton an error if you include these

I fixed it in nicolad#1

Amazing work @luca992, merged.

Now hope @lmlmt will get a chance to 👀 over this PR

remove SendAsset payload_multi_sig_user & outer_signer

This reverts commit 7b7b4ec.

…not serialize package outer_signer and payload_multi_sig_user in MultiSigExtension

This reverts commit 9145271.

This reverts commit d1fe9e2.

This reverts commit 4451ce2.

This reverts commit 3b03853.

This reverts commit 5d81c38.

This causes issues especially with message packing multi-sig transaction when for example a serde Value with a number will look like this when packed: `0x83b07369676e6174757265436861696e4964a3307831aa7369676e6174757265739183a172d942307864623433373135643037383931613063363361383937376139393534646332346664326663363063373436643734353566363133326236396163396665393734a173d942307832386236323363376364643563383230643461663832326634323336623361663361613063373938653736396235353031613331323162343634623761353835a17681bc2473657264655f6a736f6e3a3a707269766174653a3a4e756d626572a23238a77061796c6f616483ac6d756c746953696755736572d92a307832623339633062636664343763356132376636333766383832303661666239356637616661323838ab6f757465725369676e6572d92a307862373131613133636261663734316138383263373230623433363861346566323661346631613632a6616374696f6e8aa474797065a973656e644173736574b07369676e6174757265436861696e4964a730783636656565b068797065726c6971756964436861696ea7546573746e6574ab64657374696e6174696f6ed92a307836643938383538373139363035643332366664633136343839363737333432343462323762386133a9736f75726365446578a0ae64657374696e6174696f6e446578a0a5746f6b656ea455534443a6616d6f756e74a4302e3031ae66726f6d5375624163636f756e74a0a56e6f6e636581bc2473657264655f6a736f6e3a3a707269766174653a3a4e756d626572ad31373632383338313437303030` ``` { "signatureChainId": "0x1", "signatures": [ { "r": "0xdb43715d07891a0c63a8977a9954dc24fd2fc60c746d7455f6132b69ac9fe974", "s": "0x28b623c7cdd5c820d4af822f4236b3af3aa0c798e769b5501a3121b464b7a585", "v": { "$serde_json::private::Number": "28" } } ], "payload": { "multiSigUser": "0x2b39c0bcfd47c5a27f637f88206afb95f7afa288", "outerSigner": "0xb711a13cbaf741a882c720b4368a4ef26a4f1a62", "action": { "type": "sendAsset", "signatureChainId": "0x66eee", "hyperliquidChain": "Testnet", "destination": "0x6d98858719605d326fdc1648967734244b27b8a3", "sourceDex": "", "destinationDex": "", "token": "USDC", "amount": "0.01", "fromSubAccount": "", "nonce": { "$serde_json::private::Number": "1762838147000" } } } } ```

This reverts commit b79d86a.

This reverts commit c660e12.

This reverts commit 700679d.

This reverts commit 5ef467f.

luca992

nicolad#2

Side note the multisig apis you made are using SendAsset not UsdSend... it works (You can use either to send usd) but is not really named correctly.

luca992 · 2025-11-11T10:19:47Z

src/signature/create_signature.rs

+
+    let mut bytes = rmp_serde::to_vec_named(&action_without_type)
+        .map_err(|e| Error::RmpParse(e.to_string()))?;
+


nicolad#2

Got it working, but had to make a lot of fixes.

Also had to add back payload_multi_sig_user & outer_signer but with serialization disabled

Hey @luca992, isn't this the beauty of OS contribution? Thx.

Multi sig fixes

nicolad mentioned this pull request Sep 18, 2025

Parity gap with Python examples: add missing Rust src/bin samples (multi-sig, TPSL, staking, deploy, etc.) #143

Open

22 tasks

Vadim Nicolai added 2 commits October 21, 2025 13:52

Add complete multi-signature functionality with EIP-712 signing, acco…

c5d76bd

…unt conversion, address management, and transaction operations for orders, USDC transfers, and spot transfers including comprehensive tests and examples.

nicolad force-pushed the multi_sig branch from 8714039 to c5d76bd Compare October 21, 2025 11:07

luca992 reviewed Nov 8, 2025

View reviewed changes

Change requests applied

61a10da

nicolad requested a review from luca992 November 8, 2025 12:04

Vadim Nicolai and others added 2 commits November 9, 2025 15:33

Implement proper multi-sig signature collection pattern

638353b

remove SendAsset payload_multi_sig_user & outer_signer

7b7b4ec

luca992 suggested changes Nov 10, 2025

View reviewed changes

Merge pull request #1 from luca992/multi_sig

189e36f

remove SendAsset payload_multi_sig_user & outer_signer

nicolad requested a review from luca992 November 10, 2025 10:59

luca992 added 15 commits November 10, 2025 18:01

Revert "remove SendAsset payload_multi_sig_user & outer_signer"

b5e353e

This reverts commit 7b7b4ec.

add back outer_signer and payload_multi_sig_user to SendAsset but do …

fb71f22

…not serialize package outer_signer and payload_multi_sig_user in MultiSigExtension

lowercase destinations

4acc577

lowercase payload addresses

6abff7b

try signature_chain_id: "0x1"

d1fe9e2

set fixed nonce for debugging

9145271

log action_without_type

4451ce2

serde_json enable preserve_order

6960c72

preserve map order when removing from action

8c46664

insert type at the start of the action

1180276

Revert "set fixed nonce for debugging"

11a489a

This reverts commit 9145271.

Revert "try signature_chain_id: "0x1""

3b03853

This reverts commit d1fe9e2.

Revert "log action_without_type"

5d81c38

This reverts commit 4451ce2.

Reapply "try signature_chain_id: "0x1""

d5ad466

This reverts commit 3b03853.

debug with hardcoded nonce

b79d86a

luca992 added 11 commits November 11, 2025 00:44

Reapply "log action_without_type"

c45b036

This reverts commit 5d81c38.

log hex

97d4d1f

Revert "debug with hardcoded nonce"

c660e12

This reverts commit b79d86a.

serialize Signature r & s to strings

3c72658

Reapply "debug with hardcoded nonce"

700679d

This reverts commit c660e12.

MultiSigEnvelope use the signature_chain_id from the MultiSigAction

97303d3

Revert "Reapply "debug with hardcoded nonce""

48b33bd

This reverts commit 700679d.

revert debug print

2bc8732

revert adding preserve_order serde_json feature

5ef467f

Revert "revert adding preserve_order serde_json feature"

81b6f51

This reverts commit 5ef467f.

luca992 suggested changes Nov 11, 2025

View reviewed changes

Merge pull request #2 from luca992/multi_sig

33ab804

Multi sig fixes


		let mut bytes = rmp_serde::to_vec_named(&action_without_type)
		.map_err(\|e\| Error::RmpParse(e.to_string()))?;

Add multi-sig example binaries #144

Are you sure you want to change the base?

Add multi-sig example binaries #144

Uh oh!

Conversation

nicolad commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolad commented Sep 18, 2025

Uh oh!

lmlmt commented Oct 21, 2025

Uh oh!

nicolad commented Oct 21, 2025

Uh oh!

luca992 left a comment

Choose a reason for hiding this comment

Uh oh!

luca992 Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

nicolad Nov 8, 2025

Choose a reason for hiding this comment

Uh oh!

nicolad Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luca992 Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolad Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

luca992 Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

nicolad Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

nicolad Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

luca992 left a comment

Choose a reason for hiding this comment

Uh oh!

luca992 Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolad Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicolad commented Sep 18, 2025 •

edited

Loading

nicolad Nov 8, 2025 •

edited

Loading

luca992 Nov 9, 2025 •

edited

Loading

luca992 Nov 11, 2025 •

edited

Loading