Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cosmos blog section #212

Merged
merged 7 commits into from
Aug 16, 2023
Merged

Add Cosmos blog section #212

merged 7 commits into from
Aug 16, 2023

Conversation

deniseyu
Copy link
Contributor

@deniseyu deniseyu commented Aug 16, 2023

Jekyll has some strong opinions about the posts collection so I think the easiest way to do this without messing up the existing Dripline content or introducing any changes to the Dripline workflow, is to set up the Cosmos blog as a new collection.

To do:

  • Add real content
  • Verify that cosmos index page is styled correctly after actual content
  • Verify that date ordering working as expected
  • Figure out why the scope config for default layout isn't working

@tripledoublev tripledoublev changed the base branch from master to staging August 16, 2023 14:44
@tripledoublev
Copy link
Member

I changed the base branch to staging

@deniseyu deniseyu marked this pull request as ready for review August 16, 2023 15:59
@deniseyu
Copy link
Contributor Author

I'm not sure why CI is breaking - is it because the page hasn't been built yet in prod? Will that go away on its own after being merged into main?

deniseyu and others added 3 commits August 16, 2023 12:04
- Update the `permalink` setting for the `cosmos` collection in `_config.yml` to include a trailing slash.
- Adjust the permalink in `cosmos.html` to ensure the cosmos index page also has a consistent URL structure with a trailing slash.

This change resolves internal linking issues and provides consistent URL structures for the entire `cosmos` collection.
@tripledoublev
Copy link
Member

I think it was simply a matter of adding a trailing slash. Let's see how the check goes

Copy link
Member

@tripledoublev tripledoublev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tripledoublev tripledoublev self-assigned this Aug 16, 2023
@tripledoublev tripledoublev merged commit ebdd73b into staging Aug 16, 2023
1 check passed
@tripledoublev tripledoublev deleted the add-cosmos-blog branch December 4, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants