Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity pub integration #228

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Activity pub integration #228

merged 4 commits into from
Oct 17, 2023

Conversation

tripledoublev
Copy link
Member

@tripledoublev tripledoublev commented Oct 17, 2023

I did the following steps as seen in these instructions

  • Installed the plugin by adding it to our Gemfile
  • Generated a private key and added it to GH secrets
  • Added the new key flag to jekyll build in the Makefile
  • Added relevant links and meta properties to the site's head as seen on this document

Once this is published and propagated, I will run the jekyll notify command.

bundle exec jekyll notify --key ${{ secrets.DP_AP_KEY }}

Should the above command be added to the Makefile?

Anything else that I missed?

@tripledoublev
Copy link
Member Author

Adding that I will need to create additional keys for production (vs staging) and will need to separate these actions so that they each use their associated secrets

Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, defs should have separate keys for staging and prod

@tripledoublev tripledoublev merged commit 8f03fc1 into staging Oct 17, 2023
1 check passed
@tripledoublev tripledoublev deleted the activity-pub-integration branch October 17, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants