Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvements #5914

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Test improvements #5914

merged 3 commits into from
Oct 26, 2023

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Oct 26, 2023

This PR introduces these improvements in tests:

  • Use content: () => <MyComponent /> over content: () => mount(<div><MyComponent /></div>) in accessibility tests for components with a top-level Fragment, where the wrapping div was a workaround to prevent some children from being "lost" (see https://github.com/hypothesis/client/issues/5690)
  • Fix a warning printed in ToastMessages test that could make debugging other issues harder.
    image

@acelaya acelaya requested a review from robertknight October 26, 2023 09:40
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #5914 (c5b2ffb) into main (9b11269) will not change coverage.
The diff coverage is n/a.

❗ Current head c5b2ffb differs from pull request most recent head 41f756d. Consider uploading reports for the commit 41f756d to get more accurate results

@@           Coverage Diff           @@
##             main    #5914   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         257      257           
  Lines        9880     9880           
  Branches     2360     2360           
=======================================
  Hits         9825     9825           
  Misses         55       55           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acelaya acelaya merged commit 8a66d96 into main Oct 26, 2023
2 checks passed
@acelaya acelaya deleted the test-improvements branch October 26, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants