Skip to content

Remove auto-installation of mecab in setup.py to prevent password prompt during pip install #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025

Conversation

hyunwoongko
Copy link
Owner

Summary

This PR removes the automatic installation of mecab and related Python packages from setup.py. Previously, the installation process attempted to install system-level dependencies and Python packages, which could trigger password prompts (e.g., for sudo) during pip install, even inside virtual environments.

Motivation

  • Fixes the issue where pip install kss or pip install . prompts for a password on macOS and Ubuntu, both inside and outside of virtual environments.
  • Prevents privilege escalation and respects Python packaging best practices.

Details

  • The PreInstall class in setup.py no longer attempts to install mecab or its Python bindings automatically.
  • Users are now expected to install mecab and its Python bindings manually if needed.

Additional Notes

  • No changes to the core functionality of kss.
  • Please update documentation to clarify mecab installation requirements if necessary.

Closes: #<issue_number_if_known>


No pull request template was found in the repository. If a template exists elsewhere, please let me know and I will update the PR description accordingly.

@hyunwoongko hyunwoongko merged commit 84155f6 into main Aug 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants