Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option/Either: Add value or throw methods #52

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Option/Either: Add value or throw methods #52

merged 4 commits into from
Dec 21, 2022

Commits on Dec 21, 2022

  1. Option/Either: Add value or throw methods 

    Also test them.
    @jarstelfox
    jarstelfox committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    8aa9666 View commit details
    Browse the repository at this point in the history

  2. Exception: Replace with our own type 

    This allows for easy catching
    @jarstelfox
    jarstelfox committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    500a555 View commit details
    Browse the repository at this point in the history

  3. Psalm: Ignore phpunit weirdness 

    Psalm is complaining that we know we will throw and the lines below are unreachable
secrectly phpunit is catching and continuing.
    @jarstelfox
    jarstelfox committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    6418e18 View commit details
    Browse the repository at this point in the history

  4. Tests: Actually run them 

    It ends up the psalm warnings were useful in the last commit:

PHPUnit was quiting after the first throw exception.

To do more assertions, I am manually catching and checking.
    @jarstelfox
    jarstelfox committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    02d8376 View commit details
    Browse the repository at this point in the history