Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert old CRSF tests (#113) #114

Merged
merged 1 commit into from
Aug 15, 2023
Merged

revert old CRSF tests (#113) #114

merged 1 commit into from
Aug 15, 2023

Conversation

stronnag
Copy link
Collaborator

Combines old CRSF test with newer test from #78 (which broke CRSF/OpenTX)

@stronnag stronnag merged commit d938948 into master Aug 15, 2023
4 checks passed
@stronnag
Copy link
Collaborator Author

@rmaia3d could you please test that current master still behaves correctly for your diversity RX ?

@rmaia3d
Copy link
Contributor

rmaia3d commented Aug 15, 2023

Ok, I will test it as soon as possible and report the results!

@rmaia3d
Copy link
Contributor

rmaia3d commented Aug 30, 2023

Sorry for the delay, but finally had some time to test. The telemetry detection works just fine with my diversity Rx's using the lua in master branch.

However, the RFMD detection seems broken. It doesn't detect the packet rate, showing only "50Hz", regardless of what's actually being used.

I did some investigation and it looks like the data.elrs parameter is not being updated accordingly (it is not detecting the ELRS major version). It's value remains as either 0 or -1. I couldn't find the reason for that, as I couldn't locate where the initial ELRS detection calls are made, but I suspect something is broken there.

Previous version of the scripts I was running (from late Feb/2023) was running just fine (and still is). So, some change in master since then probably broke this.

@stronnag
Copy link
Collaborator Author

Thanks. I now have an ELRS RX, so I can check this.

@stronnag
Copy link
Collaborator Author

stronnag commented Sep 1, 2023

2.2.2 is working OK here. Displays the correct packet rate as set via the ELRS widget (ELRS 3)

@rmaia3d
Copy link
Contributor

rmaia3d commented Sep 9, 2023

If it is working for you, it probably was a mess up on my part. I will try testing again as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants