Skip to content

Mission control WP options and Geozones fixes #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

breadoven
Copy link
Collaborator

@breadoven breadoven commented Apr 25, 2025

Fix for iNavFlight/inav#10821.

Also fixes #2369.

Additional fix added for WP Jump P1 value. This is initially set as the geo WP number to Jump to but when the Jump WP was selected again it showed the WP index which may be different to the geo WP number ... confusing. The Jump P1 field now shows the geo WP number when the Jump WP is selected (this isn't strictly correct as the P1 value will be different to the geo WP number but it makes more sense from a user point of view).

@rts18
Copy link

rts18 commented Apr 26, 2025

Thx for the fix.
It no longer returns P1 to 0 from 1 after saving mission to eeprom.

However can I make a suggestion. It now defaults RTH P1 to 0. Requiring us to select 1 to enable landing after RTH.
In my reasoning, I'd think most people that select WP RTH would expect it to land, rather than hover above home.
How does it seem to you if the selection for RTH P1 action defaults to 1 as before?

@breadoven breadoven changed the title Mission control WP options fix Mission control WP options and Geozones fixes Apr 26, 2025
@breadoven
Copy link
Collaborator Author

Thx for the fix. It no longer returns P1 to 0 from 1 after saving mission to eeprom.

However can I make a suggestion. It now defaults RTH P1 to 0. Requiring us to select 1 to enable landing after RTH. In my reasoning, I'd think most people that select WP RTH would expect it to land, rather than hover above home. How does it seem to you if the selection for RTH P1 action defaults to 1 as before?

Problem is that for fixed wing you probably wouldn't want it to land given FW landing is usually a lottery unless landing on a large open flat field. Not sure what the solution is here. Could make it platform specific I guess which will work so long as Configurator is connected to the FC.

@breadoven
Copy link
Collaborator Author

Changed so this now defaults to RTH land for multirotors.

@rts18
Copy link

rts18 commented Apr 28, 2025

Changed so this now defaults to RTH land for multirotors.

Appreciate that. 👍

@breadoven breadoven merged commit 1f26563 into iNavFlight:master May 5, 2025
6 checks passed
@breadoven breadoven added this to the 8.1 milestone May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geozones causing issues with missions
2 participants