Mixer output mapping: prioritize dedicated timer outputs#2596
Open
sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
Open
Mixer output mapping: prioritize dedicated timer outputs#2596sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
Conversation
The output mapping preview assigned motors and servos purely by array position, ignoring timerOverrides. Targets that configure dedicated motor/servo timers in config.c saw incorrect previews. Use two-pass assignment matching firmware pwmBuildTimerOutputList(): dedicated outputs (OUTPUT_MODE_MOTORS/SERVOS) first, then auto.
|
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, even if the user specifically set MOTOR and SERVO timers (output), it would instead use the AUTO ones, disregarding the user's explicit instructions:
Now, it follows instructions - if the user sets a timer as servos, use that for servos first:
Companion firmware PR:
iNavFlight/inav#11445
Tests completed
timerOverridesconfigured (e.g. TIM1=MOTORS, TIM2=SERVOS in config.c)timerOverridesand verify output mapping preview is unchanged from previous behavior