Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiroom support #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Multiroom support #47

wants to merge 3 commits into from

Conversation

iamDecode
Copy link
Owner

@iamDecode iamDecode commented Apr 3, 2021

Basic implementation of multi-room support as proposed in #8. This change just duplicates the services for each room. Some things still left unexplored:

  • The rooms menu is currently populated statically from the rooms config file. It would be nice if more dynamic information like number of users currently in that room could be shown as well.
  • Switching rooms is currently done by refreshing the page. Thats a bit excessive, properly unloading App and loading a new one for the new room is probably better.
  • broadcast/subscribe is currently done with a bit of a hack, prefixing every namespace with the room name. Should check out if uwebsockets has some sort of scoping system for broadcasts.

Closes #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple room support
1 participant