Adds possibility to pass options through cli #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can take Cli options and send them to our tests, sometimes it is quicker to send values through command line than through gruntfile options. I think this is a good approach to give a second option.
|
I will look at merging this in soon. If you supply a test it will be merged much quicker and I won't have to write one :) |
|
ok, I think that I will have some time in the weekend so I will be able to |
|
Sorry but I haven't got time to do this. I am wondering is my approach good, because the parameters which it accepts can be passed to grunt task and they don't have to be connected with casper but casper will try to put it into spawnOpts. Please take a look are you really want your plugin to go that way and if not you can remove my pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can take Cli options and send them to our tests, sometimes it is quicker to send values through command line than through gruntfile options. I think this is a good approach to give a second option.