feat: Page number reset support with TOC integration #276
+577
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added .resetpagenumber command plus runtime support so page counters and TOC can honor per-section numbering resets; introduced PageNumberReset AST node, HTML markers, paged/slides JS logic, and tests. - Added mock doc pagenum.qd to demonstrate page numbering (margin footer, explicit page breaks, reset scenario) and fixed line endings so manual tests align with CLI behavior.
- Added unique identifiers to PageMarginContentInitializer, updated the HTML renderer to emit data-margin-* metadata plus paired .page-margin-switch markers, and expanded the mock demo so each page shows a distinct footer alongside .resetpagenumber. - Switched the page margins handler to track initializers in a Map, read per-page switches, and apply only the active initializer per margin slot; rewrote the Vitest specs to use a recording handler that asserts both collection and application.
- Add `updateTableOfContentsPageNumbers()` method in TypeScript runtime to inject reset-aware page numbers into TOC links - Add `data-role="table-of-contents"` attribute to TOC nav element in Kotlin renderer for runtime hook identification - Update SCSS layout: make TOC list items flexbox containers with `flex-wrap: wrap` to ensure section numbers, titles, and page numbers display on a single line - Add tests verifying TOC page numbers respect reset markers in paged documents - Update demo document with `.tableofcontents` and `.resetpagenumber` markers
Add resetCounter() method to PageMarginContentInitializer and call it in @BeforeTest setUp() for PageMarginsTest and PersistentHeadingTest. Update expected margin IDs in assertions to start from 1 after reset. Fixes test failures during clean builds caused by global counter state persisting across test executions.
sanoakr
force-pushed
the
pagenumbering
branch
from
1fabf6e to
10113fc
Compare
Owner
|
Hey @sanoakr, I tested it and seems nice! I'm just confused about your second commit: what do you mean by scoped page margins? From what I see it's not closely related to the main feature; if that's true I'd rather have them split into smaller PRs to review more carefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement page number reset functionality with automatic integration into the table of contents. This feature allows documents to reset their page numbering at specific points while maintaining correct references in the TOC.
Changes
This PR includes 3 commits:
Add page-number reset support (
b0cdc097d).resetpagenumbercommand for resetting page numbers at any pointScoped page margins with reset demo (
2062400a3)Display reset-aware page numbers in table of contents (
6a4343167)Testing
mock/pagenum.qd) demonstrates the featureType