Only remove rows if deleteRowCallback doesn’t return `false` #237

SimonSimCity · 2016-11-17T12:21:59Z

Fixes #235

This change is

malkomich

I would use a promise to make some stuff asynchronously before check if deletion can be done. For example, if you want to delete from DB before removing the table entry, and when the deletion promise is well resolved you want the entry to be removed.

SimonSimCity added 2 commits November 17, 2016 16:18

Only remove rows if deleteRowCallback doesn’t return false

d110ea5

Fixed variable

2253f3f

malkomich suggested changes Feb 2, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only remove rows if deleteRowCallback doesn’t return `false` #237

Only remove rows if deleteRowCallback doesn’t return `false` #237

SimonSimCity commented Nov 17, 2016 •

edited by iamisti

Loading

malkomich left a comment

Only remove rows if deleteRowCallback doesn’t return false #237

Are you sure you want to change the base?

Only remove rows if deleteRowCallback doesn’t return false #237

Conversation

SimonSimCity commented Nov 17, 2016 • edited by iamisti Loading

malkomich left a comment

Choose a reason for hiding this comment

Only remove rows if deleteRowCallback doesn’t return `false` #237

Only remove rows if deleteRowCallback doesn’t return `false` #237

SimonSimCity commented Nov 17, 2016 •

edited by iamisti

Loading