Skip to content

fix: add missing RenderTextProps export #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christianhg
Copy link
Contributor

renderText was introduced in #5850, but the prop types didn't get exported with it.

Copy link

changeset-bot bot commented May 7, 2025

🦋 Changeset detected

Latest commit: 759c53a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@12joan
Copy link
Contributor

12joan commented May 7, 2025

@christianhg Thanks! Please could you add a changeset using yarn changeset so that merging this PR will release a new version of slate-react?

---
"slate-react": patch
---

Add missing `RenderTextProps` export

`renderText` was introduced in ianstormtaylor#5850, but the prop types didn't get exported
with it.
@christianhg christianhg force-pushed the fix-export-render-text-props branch from e7c7eeb to 759c53a Compare May 7, 2025 07:03
@christianhg
Copy link
Contributor Author

@christianhg Thanks! Please could you add a changeset using yarn changeset so that merging this PR will release a new version of slate-react?

---
"slate-react": patch
---

Add missing `RenderTextProps` export

Hi @12joan ! I just did that 😄

I wrote:

fix: add missing RenderTextProps export

But perhaps the fix: prefix is redundant in the changeset? It's been a while since I used these.

@12joan
Copy link
Contributor

12joan commented May 7, 2025

But perhaps the fix: prefix is redundant in the changeset? It's been a while since I used these.

All good! It probably autofilled the changeset from your commit message. So long as a person reading the changelog can understand what the changes are, it doesn't matter too much how you phrase it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants