Check if editor is still mounted before trying to focus #5916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
DOMEditor.focus
method has a retry mechanism built in. It can happen, that while retrying to focus the dom node of the editor, meanwhile the editor has been unmounted, which will result in an error when callingDOMEditor.toDOMNode(editor, editor)
.This PR adds a check on top of the
DOMEditor.focus
method, to check if the editor is still mounted, if not return and do not retry to focus the editor dom node anymore.Issue
Fixes: #5915
Context
This error happened in our unit tests. I guess it's hard to reconstruct in the browser, since it is happening in the milliseconds area.
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)