Skip to content

Generic return type for Node.fragment #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

12joan
Copy link
Contributor

@12joan 12joan commented Jul 31, 2025

Description
Use generics for the return type of Node.fragment so that it matches the children of the root you pass in.

Example

interface ParagraphElement extends BaseElement {
  type: 'paragraph'
  children: InlineNode[]
}

// Type of fragment is InlineNode[]
const fragment = Node.fragment(paragraph, range)

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Jul 31, 2025

🦋 Changeset detected

Latest commit: b7307ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant