IBX-8837: Distraction free mode: Text obstruction by toolbar's fixed position #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bozatko
approved these changes
Oct 18, 2024
tischsoic
requested changes
Oct 18, 2024
| @@ -16,6 +17,43 @@ | |||
| activeFieldEdit.classList.toggle('ibexa-field-edit--distraction-free-mode-active', active); | |||
| editorInstance.set('distractionFreeModeActive', active); | |||
|
|
|||
| if (active) { | |||
There was a problem hiding this comment.
Should we safeguard the possibility of calling changeDistractionFreeModeState two times in a row with the same active parameter value by e.g. checking whether clearedPositionNodesData is not empty?
| if (active) { | ||
| let parentElement = activeFieldEdit.parentNode; | ||
|
|
||
| while (parentElement && parentElement !== doc.body) { |
There was a problem hiding this comment.
I think this new fragment may be more readable if split into two functions e.g. resetAncestorsPositions(), restoreAncestorsPositions()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This bug is caused by CKEditor code itself, I've created issue there ckeditor/ckeditor5#17241 but I doubt it will be resolved soon (if ever), judging from my experience, so here's fix for it.
I'm basically temporarly removing styles that breaks supossed correct behaviour, as distraction free mode takes whole page, it doesn't matter what happens beneath, as it's not visible. When closing DFM I restore remove my inline styles/restore previous inline styles
For QA:
This solves https://issues.ibexa.co/browse/IBX-8965 as well, I think.
Documentation: