IBX-9169: Enable searching by content's name in the Trash #1388
+64
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
added
Improvement
Ready for review
Feature
ViniTou
approved these changes
Nov 4, 2024
konradoboza
approved these changes
Nov 4, 2024
|
However, as I understand why and this beeing low cost - question is should it just target 5.0 to be rules obidient. |
|
@ViniTou it's highly requested unfortunately lately so I think we need to bend the rules a bit here |
dew326
approved these changes
Nov 4, 2024
tbialcz
approved these changes
Nov 5, 2024
adamwojs
reviewed
Nov 5, 2024
|
@adamwojs done, please see the ticket's description for updated looks |
barw4
force-pushed
the
ibx-9169-search-content-by-name-trash
branch
from
b42563c
to
58f8508
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
ibexa/core#448
Description: