refactor(memtables)!: remove support for problematic memtable properties #11465
+260
−550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
changed the title
github-actions
bot
added
tests
cpcloud
force-pushed
the
remove-memtable-names
branch
from
59067a1 to
b0ae55d
Compare
cpcloud
commented
Jul 16, 2025
| @@ -1714,16 +1715,6 @@ def _register_in_memory_table(self, op: ops.InMemoryTable) -> None: | |||
|
|
|||
| self.con.register(op.name, obj) | |||
|
|
|||
| def _finalize_memtable(self, name: str) -> None: | |||
| # if we don't aggressively unregister tables duckdb will keep a | |||
| # reference to every memtable ever registered, even if there's no | |||
There was a problem hiding this comment.
This is still true, but very hard to manage automatically without baking assumptions about when GC runs generically into all Ibis backends AFAICT, so I've reverted to the previous behavior.
cpcloud
force-pushed
the
remove-memtable-names
branch
5 times, most recently
from
9694099 to
7b37bfa
Compare
cpcloud
force-pushed
the
remove-memtable-names
branch
2 times, most recently
from
ede74d1 to
3804fe1
Compare
cpcloud
force-pushed
the
remove-memtable-names
branch
from
3804fe1 to
df7947c
Compare
cpcloud
force-pushed
the
remove-memtable-names
branch
3 times, most recently
from
da89671 to
f96a198
Compare
Allowing explicit naming of memtables creates problems. This commit removes that ability and prevents deadlocks during Python GC. BREAKING CHANGE: `memtable`s can no longer be named explicitly, please use `create_table` or `create_view` to create a named object instead.
BREAKING CHANGE: `ibis.case()` is removed. Use `ibis.cases()` instead.
BREAKING CHANGE: `IntegerValue.to_timestamp` is removed. Use `IntegerValue.as_timestamp` instead.
BREAKING CHANGE: `IntegerValue.to_interval` is removed. Use `IntegerValue.as_interval` instead.
BREAKING CHANGE: `String.to_timestamp` method is removed in favor of `String.as_timestamp`.
BREAKING CHANGE: `String.to_date` is removed in favor of `String.as_date`.
BREAKING CHANGE: `Struct.destructure` is removed in favor of `Table.unpack`.
cpcloud
force-pushed
the
remove-memtable-names
branch
from
f96a198 to
ab85a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11464.