Skip to content

feat(api): always prefer overwriting existing fields when unpacking with overlapping column names #11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 17, 2025

Previous the behavior of overlapping column names was to error when an unpacked struct field clashed with an existing column. This PR changes the behavior to always overwrite existing columns.

@github-actions github-actions bot added the tests Issues or PRs related to tests label Jul 17, 2025
@cpcloud cpcloud force-pushed the define-overwrite-behavior-with-unpack branch 4 times, most recently from 82fd449 to 152da9a Compare July 20, 2025 11:00
@cpcloud cpcloud force-pushed the define-overwrite-behavior-with-unpack branch from 152da9a to f6eedad Compare July 20, 2025 11:00
@cpcloud cpcloud merged commit 8027d51 into ibis-project:main Jul 20, 2025
109 of 110 checks passed
@cpcloud cpcloud deleted the define-overwrite-behavior-with-unpack branch July 20, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant