docs: clarify get_name behavior with DuckDB and temp views #11476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
requested changes
Jul 24, 2025
| @@ -140,7 +140,17 @@ def __bool__(self) -> bool: | |||
| __nonzero__ = __bool__ | |||
|
|
|||
| def get_name(self): | |||
| """Return the name of this expression.""" | |||
| """ | |||
| Return the (possibly unqualified) name of the table. | |||
There was a problem hiding this comment.
This isn't correct. This get_name() implementation is implement on the base class of scalar, column, and table expressions. Any discussion of tables should be on the corresponding subclass.
Also, the formatting here doesn't follow any of the surrounding docstring formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issues closed