-
Notifications
You must be signed in to change notification settings - Fork 22
Add IO processor for certainty intrinsic #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Notebook CI tests failing due to disk space issue. Not sure how to fix that. |
Try adding disk cleanup (https://github.com/ibm-granite/granite-io/blob/main/.github/workflows/test.yml#L59C7-L60C48) before setting up Python (https://github.com/ibm-granite/granite-io/blob/main/.github/workflows/test_examples.yml#L58) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a shallow review not but noticed vLLM backend and also potential fix for the ci disk issue. Will return later to review further.
Signed-off-by: Fred Reiss <[email protected]>
Thanks, adding that step to the workflow has cleared up the CI issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see questions inline
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: Fred Reiss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frreiss Some small things
Signed-off-by: Fred Reiss <[email protected]>
Martin said on internal slack that this was okay
Looks good to go. Just some small comments. @mark.sturdevant I'll leave it to you to decide
... and I feel like we need to merge it and iterate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this and then iterate on things like supportability, usability, docs, test limitations...
This PR adds an IO processor for the Granite certainty intrinsic, AKA the Granite 3.2 8B Instruct Uncertainty LoRA.
In addition to the IO processor, I've also added some support functionality to the library:
I also include a notebook and test cases.