Skip to content

Query Expansion IO Processor #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 14, 2025
Merged

Query Expansion IO Processor #191

merged 12 commits into from
Jun 14, 2025

Conversation

pvn25
Copy link
Contributor

@pvn25 pvn25 commented Jun 9, 2025 •
edited
Loading

  • Chat completion request calls 5 different querying methods (last-turn query, query rewrite LoRA, Sampling answer, Reverse-engineering the question from the answer, Synonymous query rewrite) under the hood
  • Each method call is executed independently (except method that reverse-engineers the question)

@frreiss frreiss closed this Jun 10, 2025
@frreiss frreiss reopened this Jun 10, 2025
@frreiss
Copy link
Collaborator

frreiss commented Jun 10, 2025

Thanks for the contribution, @pvn25! Can you please fix the linter warnings in the CI output?

frreiss
frreiss requested changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Linter issues need to be resolved to get this PR past CI. Some additional suggestions inline. It would also be helpful to have a basic regression test for this IO processor.

@pvn25 pvn25 force-pushed the query_expansion_io branch 2 times, most recently from 0dc0ce9 to eaf7195 Compare June 12, 2025 00:13
pvn25 and others added 10 commits June 13, 2025 22:35
@pvn25
add query expansion io processor
da9de26 
Signed-off-by: vraj <[email protected]>
@pvn25
add query expansion IO processor and test notebook
ed35d1c 
Signed-off-by: vraj <[email protected]>
@pvn25
add query expansion IO processor
5b2b49a 
Signed-off-by: vraj <[email protected]>
@frreiss @pvn25
Fix dependencies
3908f68 
Signed-off-by: Fred Reiss <[email protected]>
Signed-off-by: vraj <[email protected]>
@pvn25
update init file
cc95f1f 
Signed-off-by: vraj <[email protected]>
@pvn25
Reordering inference calls
69cd2db 
Signed-off-by: vraj <[email protected]>
@pvn25
remove print stmts
1df5edb 
Signed-off-by: vraj <[email protected]>
@pvn25
update query expansion notebook
2402a07 
Signed-off-by: vraj <[email protected]>
@pvn25
add query expansion test
4ce3beb 
Signed-off-by: vraj <[email protected]>
@pvn25
add simple query expansion test
b9488c7 
Signed-off-by: vraj <[email protected]>
@pvn25 pvn25 force-pushed the query_expansion_io branch from e5979d9 to b9488c7 Compare June 13, 2025 22:35
@pvn25
Copy link
Contributor Author

pvn25 commented Jun 13, 2025

Thank you @frreiss for your comments. I addressed your comments and added a very simple test. Pls lmk if this needs more changes.

@frreiss frreiss merged commit 9f76036 into ibm-granite:main Jun 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frreiss frreiss frreiss requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvn25 @frreiss