Skip to content

Update Citations I/O processor for Granite 3.3 LoRA #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 14, 2025

Conversation

yannisk2
Copy link
Contributor

This PR updates the citations I/O processor to support the Granite 3.3 citations generation LoRA.

It contains the following changes:

  • Update the citations output processor to work on top of the updated output schema of the Granite 3.3 LoRA (designed to make it easier to perform constrained decoding).
  • Updates the citations notebook to use Granite 3.3 to generate the assistant response and the Granite 3.3 citations generation LoRA to generate the citations for that response

Note: The PR currently includes a local copy of the Granite 3.3 citations generation LoRA adapter for testing. Once the LoRA adapter is published on HuggingFace, the PR will be modified to point to the location of the published LoRA adapter instead.

@frreiss
Copy link
Collaborator

frreiss commented Jun 11, 2025

@yannisk2 thanks for the updates. Would you mind running ruff format on the updated notebook file to clear the CI check?

@yannisk2
Copy link
Contributor Author

@frreiss FYI, I fixed the linter issues and also updated the unit tests for the citations I/O processor.

Copy link
Collaborator

@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frreiss frreiss marked this pull request as ready for review June 14, 2025 01:08
@frreiss frreiss merged commit b868e18 into ibm-granite:main Jun 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants