Skip to content

Query Rewrite and Context Relevancy IO Processors for Granite 3.3 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jun 23, 2025

Conversation

krishnatejakk
Copy link
Contributor

  • Added IO processors for both query rewrite and context relevancy intrinsics
  • Updated the example notebooks as well

Copy link
Collaborator

@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed, see comments inline.

@krishnatejakk krishnatejakk requested a review from frreiss June 16, 2025 12:05
@krishnatejakk
Copy link
Contributor Author

@frreiss — I’ve resolved the Ruff errors in the latest commit. The tweaks I made to clear the PyLint warnings briefly introduced some Ruff line-length issues, but those are now fixed as well.

@krishnatejakk
Copy link
Contributor Author

@frreiss I have updated the query rewrite notebook to use the huggingface query rewrite model.

Copy link
Collaborator

@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer to ready, but several aspects of this change set will break CI. See comments inline.

@krishnatejakk krishnatejakk requested a review from frreiss June 21, 2025 16:34
@frreiss frreiss merged commit c9e9bc9 into ibm-granite:main Jun 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants