Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding abiltity to alter MQTT version using either envVars or ConfigFile #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonahLuckett
Copy link
Contributor

May be redundant due to the current inability to use MQTTv5 but this way we're ready for the node update if we wanted to be.

May be redundant due to the current inability to use MQTTv5 but this way we're ready for the node update if we wanted to be.
@JonahLuckett JonahLuckett requested a review from durera July 18, 2019 22:45
@durera
Copy link
Contributor

durera commented Dec 23, 2019

After various discussions today, have decided that we'll support MQTTv5 by making it a replacement for v3.1.1 rather than an alternative/configuration option ... supporting multiple versions will create additional overheads in terms of testing and code paths that we'll need to maintain as we start to take advantage of the v5 features, so after consideration we're going to tweak how we do this. Will discuss with you @JonahIBM once you're back from xmas hols .. should be a few simple tweaks we can make here to make it so that "it's just MQTT v5"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants