Move getting native pointer to ECUtils and acquire during init #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostasTsiounis
force-pushed
the
nativepointer_check
branch
from
853813e to
841e238
Compare
keithc-ca
requested changes
May 27, 2024
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDSASignature.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDSASignature.java
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECUtil.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECUtil.java
Outdated
Show resolved
Hide resolved
keithc-ca
requested changes
May 27, 2024
closed/src/java.base/share/classes/sun/security/ec/NativeECUtil.java
Outdated
Show resolved
Hide resolved
KostasTsiounis
force-pushed
the
nativepointer_check
branch
from
5bcd417 to
9c8e09a
Compare
keithc-ca
reviewed
May 27, 2024
closed/src/java.base/share/classes/sun/security/ec/NativeECDSASignature.java
Outdated
Show resolved
Hide resolved
KostasTsiounis
force-pushed
the
nativepointer_check
branch
from
1a46f1e to
68cad76
Compare
|
Please update the commit message, so the summary better captures what this change is about and add some detail to the body of the commit message: that's the best place for the information for someone looking at this years later. |
The acquisition of a native pointer for an EC key, private or public, is being moved to the ECUtil, instead of the implementation classes of said keys. This allows use of interop keys, rather than just keys coming from SunEC. The methods to get the pointers to the native keys are called during the initialization phases, to discover the possibility of not being able to utilize the native code and revert to the Java implementation early. The engineUpdate() methods of the RawECDSA subclass are, also, updated to use the java implementation, if one has been initialized. Signed-off by: Kostas Tsiounis <[email protected]>
KostasTsiounis
force-pushed
the
nativepointer_check
branch
from
68cad76 to
5615b8e
Compare
|
Is that OK? |
|
Jenkins test sanity zlinux jdknext |
|
Grinders:
|
keithc-ca
approved these changes
May 28, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acquisition of a native pointer for an EC key, private or public, is being moved to the
ECUtil, instead of the implementation classes of said keys. This allows use of interop keys, rather than just keys coming fromSunEC.The methods to get the pointers to the native keys are called during the initialization phases, to discover the possibility of not being able to utilize the native code and revert to the Java implementation early.
The
engineUpdate()methods of theRawECDSAsubclass are, also, updated to use the java implementation, if one has been initialized.Signed-off by: Kostas Tsiounis [email protected]