Support brainpoolP512r1 TLS 1.3 RFC 8734 #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkatonica
force-pushed
the
katonica/feature/brainpoolnext
branch
2 times, most recently
from
eba8de6 to
967731e
Compare
keithc-ca
requested changes
Jun 7, 2024
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDSASignature.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDSASignature.java
Outdated
Show resolved
Hide resolved
jasonkatonica
force-pushed
the
katonica/feature/brainpoolnext
branch
9 times, most recently
from
81d80cf to
2705bd9
Compare
keithc-ca
requested changes
Jun 12, 2024
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECKeyPairGenerator.java
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECKeyPairGenerator.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECKeyPairGenerator.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECUtil.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECUtil.java
Outdated
Show resolved
Hide resolved
jasonkatonica
force-pushed
the
katonica/feature/brainpoolnext
branch
from
9efd824 to
8a5eeb6
Compare
keithc-ca
requested changes
Jun 13, 2024
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/sun/security/ec/NativeECDHKeyAgreement.java
Outdated
Show resolved
Hide resolved
keithc-ca
requested changes
Jun 14, 2024
src/java.base/share/classes/sun/security/ssl/SignatureScheme.java
Outdated
Show resolved
Hide resolved
jasonkatonica
force-pushed
the
katonica/feature/brainpoolnext
branch
from
daa15a3 to
28a72f1
Compare
|
This looks good, but please squash, and then mark as "ready for review" when you're ready. |
jasonkatonica
force-pushed
the
katonica/feature/brainpoolnext
branch
from
28a72f1 to
20cd9ec
Compare
This update supports both the `ecdsa_brainpoolP512r1tls13_sha512` signature scheme and `brainpoolP512r1tls13` key exchange mechanisms defined in `RFC 8734` using `openssl`. The `NativeECDHKeyAgreement` class was enhanced to allow for a key exchange to take place using the EC named curve `brainpoolP512r1`. This functionality can be enabled by configuring the named group `brainpoolP512r1tls13`. The `NativeECDSASignature` class was enhanced to allow for `ECDSA` `brainpoolP512r1` signatures to be routed to openssl for execution. The `NativeECKeyPairGenerator` was enhanced to allow for `brainpoolP512r1` based keys to be generated with openssl. Both the `ecdsa_brainpoolP512r1tls13_sha512` signature scheme and `brainpoolP512r1tls13` key exchange mechanism are optionally configured and not enabled by default. Tests were added to exercise both the signature scheme and key exchange along with sign and verify using the `brainpoolP512r1` named curve. Signed-off-by: Jason Katonica <[email protected]>
jasonkatonica
force-pushed
the
katonica/feature/brainpoolnext
branch
from
20cd9ec to
0370f64
Compare
|
Jenkins compile aix,zlinux jdknext |
|
Grinder for jdk_security3 https://openj9-jenkins.osuosl.org/job/Grinder/3747 passed except for known failures discussed in eclipse-openj9/openj9#19499. |
keithc-ca
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update supports both the
ecdsa_brainpoolP512r1tls13_sha512signature scheme and
brainpoolP512r1tls13key exchange mechanismsdefined in
RFC 8734usingopenssl.The
NativeECDHKeyAgreementclass was enhanced to allow for a keyexchange to take place using the EC named curve
brainpoolP512r1. Thisfunctionality can be enabled by configuring the named group
brainpoolP512r1tls13.The
NativeECDSASignatureclass was enhanced to allow forECDSAbrainpoolP512r1signatures to be routed to openssl for execution.The
NativeECKeyPairGeneratorwas enhanced to allow forbrainpoolP512r1based keys to be generated with openssl.Both the
ecdsa_brainpoolP512r1tls13_sha512signature scheme andbrainpoolP512r1tls13key exchange mechanism are optionally configuredand not enabled by default.
Tests were added to exercise both the signature scheme and key exchange
along with sign and verify using the
brainpoolP512r1named curve.Signed-off-by: Jason Katonica [email protected]