Skip to content

feat: external support RegExp and not external sub path of package #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

XGHeaven
Copy link
Collaborator

No description provided.

@XGHeaven XGHeaven requested a review from Copilot April 17, 2025 03:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the external dependencies handling to support RegExp and array configurations, and revises the related documentation and types accordingly.

  • Updated documentation in config.md to reflect the new externals types and defaults.
  • Extended externals type and handling in types.ts and getRollupOptions.ts to support arrays including RegExp.
  • Expanded the list of built-in modules in builtinModules.ts and made minor naming updates in workflows and changesets.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
website/docs/reference/config.md Updated documentation to describe new externals support.
packages/pkg/src/types.ts Modified externals type to include arrays with RegExp and objects.
packages/pkg/src/helpers/getRollupOptions.ts Updated logic to process externals array including RegExp support.
packages/pkg/src/helpers/builtinModules.ts Added additional Node built-in modules with node: prefix.
.github/workflows/release-next.yml Renamed the release workflow for clarity.
.changeset/dry-pots-buy.md Updated changeset with the new external support feature.
Comments suppressed due to low confidence (1)

packages/pkg/src/helpers/builtinModules.ts:72

  • The module 'node:sea' does not appear to be a standard Node built-in. Verify if this entry is a typo or if it is intentionally included.
'node:sea',

Copy link

pkg-pr-new bot commented Apr 17, 2025

More templates

@ice/create-pkg

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/create-pkg@673

ice-npm-utils

npm i https://pkg.pr.new/ice-lab/icepkg/ice-npm-utils@673

@ice/pkg-plugin-docusaurus

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg-plugin-docusaurus@673

@ice/pkg-plugin-jsx-plus

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg-plugin-jsx-plus@673

@ice/pkg

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg@673

@ice/pkg-plugin-rax-component

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/pkg-plugin-rax-component@673

@ice/remark-react-docgen-docusaurus

npm i https://pkg.pr.new/ice-lab/icepkg/@ice/remark-react-docgen-docusaurus@673

commit: 976fdce

@XGHeaven XGHeaven mentioned this pull request Mar 4, 2025
27 tasks
@XGHeaven XGHeaven merged commit 9f732e5 into next Apr 17, 2025
4 checks passed
@XGHeaven XGHeaven deleted the feat/new-external branch April 17, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant