Shahsawood #26
Open
Shahsawood #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichtrojan
reviewed
Dec 22, 2024
Comment on lines
+1
to
+13
| <?php | ||
|
|
||
| return [ | ||
| /** | ||
| * The length of the token | ||
| */ | ||
| 'length' => 4, | ||
|
|
||
| /** | ||
| * The validity of the token in minutes | ||
| */ | ||
| 'validity' => 10, | ||
| ]; |
There was a problem hiding this comment.
rename file to otp.php
add the validation messages in here too
ichtrojan
reviewed
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request introduces the following changes:
Refactored the hard-coded configuration of validity duration and the length of the token. Now, these configurations are set up in
config/ichtrojan-otp.phpto allow easy customization for a project. This change ensures that the length and duration of OTP remain configurable at the project level.Refactored validation messages to be retrieved from translation files, enhancing support for localization. To implement this, users are advised to set validation keys in
validation.php. Add the following entries to yourvalidation.phpfile:These entries will allow users to customize the validation messages for the package according to their needs.
Please review and merge these changes at your earliest convenience. If there are any further adjustments needed or if you have questions, feel free to let me know.