feat: Add partner fees #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAndell
commented
May 19, 2025
| } else { | ||
| calls.push( | ||
| MoneyMarketService.encodeBorrow( | ||
| { asset: vaultAddress, amount: amount, interestRateMode: 2n, referralCode: 0, onBehalfOf: from }, | ||
| moneyMarketConfig.lendingPool, | ||
| ), | ||
| ); | ||
| if (fee && feeAmount) { | ||
| calls.push(Erc20Service.encodeTansfer(vaultAddress, fee?.address, feeAmount)) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We need to remove the fee from amount sent to user
| calls.push(Erc20Service.encodeApprove(intent.inputToken, intentsContract, intent.inputAmount)); | ||
| // user has to send input amount + fee amount to the intent contract | ||
| const totalInputAmount = intent.inputAmount + feeAmount; | ||
| calls.push(Erc20Service.encodeApprove(intent.inputToken, intentsContract, totalInputAmount)); |
There was a problem hiding this comment.
Even though we add this here, each createIntent in each spoke takes the Intent amount as input
| @@ -49,6 +64,8 @@ export class EvmSolverService { | |||
| `hub asset not found for spoke chain token (intent.outputToken): ${createIntentParams.outputToken}`, | |||
| ); | |||
|
|
|||
| const [feeData, feeAmount] = EvmSolverService.createIntentFeeData(fee, createIntentParams.inputAmount); | |||
There was a problem hiding this comment.
This might have been the wrong place to place this, Most services do not use this a outer function so fee data is not propagate properly via ex createAndSubmitIntent
|
@R0bi7 is attempting to deploy a commit to the ICON Foundation PRO team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
AntonAndell
commented
May 20, 2025
| */ | ||
| public static async createIntent<R extends boolean = false>( | ||
| public static async createIntentDeposit<R extends boolean = false>( |
There was a problem hiding this comment.
Just questioning if this function is needed at all currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: of adding partner fees