Skip to content

feat: solana interface wallet support #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2025

Conversation

dhunganasaroj3
Copy link
Contributor

@dhunganasaroj3 dhunganasaroj3 commented Jun 23, 2025

Description

Describe what have you done and which # issue does this PR closes.

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sodax-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 2:57am
sodax-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 2:57am

@swiftcc624
Copy link
Contributor

swiftcc624 commented Jun 30, 2025

  • ALL commits must have verified signatures.
    You need to make a verified commit again and force-push

  • Deployment failed

@swiftcc624 swiftcc624 merged commit 91a9fea into main Jul 3, 2025
6 of 7 checks passed
@swiftcc624 swiftcc624 deleted the feat/solana-interface-wallet-support branch July 3, 2025 02:56
Comment on lines +18 to +25
readonly connection: Connection;
getWalletAddress: () => Promise<string>;
getWalletAddressBytes: () => Promise<`0x${string}`>;
sendTransaction: (transaction: VersionedTransaction) => Promise<Hash>;
buildV0Txn: (instructions: TransactionInstruction[], signers: Keypair[]) => Promise<VersionedTransaction>;
getAddress: () => PublicKey;
getWallet: () => Keypair;
getAssociatedTokenAddress: (mint: PublicKey) => Promise<PublicKey>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types must be "raw" meaning we define them and they only use primitive types. See EVM Wallet Provider interface example

0xmilktea added a commit that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(sdk): Add Solana interface wallet support
3 participants