feat(sdk): sonic solver swap #130
Draft
+1,137
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AntonAndell
requested changes
Jun 24, 2025
There was a problem hiding this comment.
Looks good except for canceling intents. Since the create will be the users router it will receive cancelled funds instead of the user itself. It would be much better if in create Intent we use the users wallet as creator instead of using the router. Then when cancelling calling also directly without the router
Comment on lines
-548
to
557
| const creatorHubWalletAddress = await EvmWalletAbstraction.getUserHubWalletAddress( | ||
| const creatorHubWalletAddress = await WalletAbstractionService.getUserHubWalletAddress( | ||
| params.srcChain, | ||
| walletAddressBytes, | ||
| this.hubProvider, | ||
| spokeProvider, | ||
| ); | ||
|
|
There was a problem hiding this comment.
For intents we dont necessarily need to use a wallet abstraction as all but we can.
We just need to make sure cancel and intent results end up in the users wallets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sonic spoke implementation of solver.
Checklist