-
-
Notifications
You must be signed in to change notification settings - Fork 194
Icosa integration #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andybak
wants to merge
222
commits into
main
Choose a base branch
from
feature/icosa-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Icosa integration #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after submit (was still double triggering for some reason)
[CI BUILD]
…tion # Conflicts: # Assets/Settings/Localization/Strings/Strings Shared Data.asset
…tion # Conflicts: # Packages/manifest.json
The following package files were changed:
The following files from ProjectSettings were changed:
(Review: flagged files) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration with Icosa Gallery API for both the Sketchbook panel (loading sketches) and the Icosa Panel (previously the Poly panel - for loading 3d models).
This PR has parity with previous Poly functionality with enhancements in terms of search and filtering. Also - the API backend is configurable and custom instances of the Icosa Gallery can be swapped in.