DACKAR Architecture Design #21

wangcj05 · 2025-08-15T17:25:58Z

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

What are the significant changes in functionality due to this change request?

Create a workflow manager to manager different calculations
Use toml as input file/config to guide analysis
Use Json validation schema to validate toml input
Currently accepted calculations: nlp.ner, nlp.causal, and load data through neo4j

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

1. Review all computer code.
2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
3. Make sure the Python code and commenting standards are respected.
4. Automated Tests should pass.
5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

…wangc/architecture

mandd

this in my initial set of comments, i'd like to give a second pass to this MR and meet with you again to talk about about this MR

mandd · 2025-09-12T20:57:31Z

src/dackar/main.py

+logger.addHandler(fh)
+
+def main():
+  logger.info('Welcome to use DACKAR!')


suggestion:
print(""":::::::-. :::. .,-::::: ::: . :::. :::::::..
;;, ';, ;;;; ,;;;'````' ;;; .;;,. ;;;; ;;;;``;;;; [[ [[ ,[[ '[[, [[[ [[[[[/' ,[[ '[[, [[[,/[[['
$$, $$c$$$cc$$$c $$$ $$$$, c$$$cc$$$c $$$$$$c
888,o8P' 888 888,`88bo,__,o,"888"88o, 888 888,888b "88bo,
MMMMP"` YMM ""` "YUMMMMMP"MMM "MMP"YMM ""` MMMM "W" '
""")

Sorry, what do you mean here?

mandd · 2025-09-12T21:22:14Z

src/dackar/workflows/WorkOrderProcessing.py



 class WorkOrderProcessing(WorkflowBase):
  """


we talked about renaming this pipeline

same applies to operator shift logs

Addressed in PR #22

mandd · 2025-09-12T21:28:49Z

system_tests/dackar.toml

+[neo4j]
+uri = "neo4j://localhost:7687"
+pwd = "123456789"
+config_file_path = "/Users/wangc/Library/Application Support/Neo4j Desktop/Application/relate-data/dbmss/dbms-28cea4a5-ad08-4fed-94a1-70d44e297586/conf/neo4j.conf"


should we remove this personal information?

addressed in PR #22

mandd · 2025-09-12T22:22:14Z

src/dackar/workflows/WorkOrderProcessing.py



 class WorkOrderProcessing(WorkflowBase):
  """


same applies to operator shift logs

mandd · 2025-09-12T22:25:36Z

src/dackar/workflows/WorkOrderProcessing.py


 class WorkOrderProcessing(WorkflowBase):
  """
    Class to process CWS work order dataset


remove CWS reference

mandd · 2025-09-12T22:36:34Z

system_tests/kg.toml

+[neo4j]
+uri = "neo4j://localhost:7687"
+pwd = "123456789"
+# User need to set the import folder, and all files for nodes and edges are using relative path to the import folder


should we anonymize these lines?

addressed in PR #22

wangcj05 · 2025-09-25T20:50:17Z

@mandd FYI, I have addressed your comments in a different PR, i.e., PR#22

mandd · 2025-09-25T21:14:35Z

Test board is green. MR is good on my end. Thanks!

wangcj05 added 30 commits July 8, 2025 13:39

some draft

afddcfc

add dackar main file

88fa7ee

add dackar input

152309d

Merge branch 'main' into wangc/architecture

1384517

Merge branch 'wangc/architecture' of github.com:idaholab/DACKAR into …

8572b98

…wangc/architecture

initial setup for dackar main control module

ba04acb

initial draft for dackar main

06879dd

some improvement

533e8fc

add workflow manager module

fa118ae

restructure functions

3327d8e

add wordcloud

4775da5

enable preprocessing in workflow manager

86ea616

enable NER setup in workflow manager

751c71e

enable causal flow

31d2d88

update input structure

f67b696

add jsonschema for input validation

3dc174b

identify the problematic data

435e61a

using logger, add docstring

2563491

update schema

f55685e

enable analysis logic in dackar calculation

6682dd1

update validation

391a8b5

enable outputs for NER

6f3f040

enable entity status output

928dcce

enable causal outputs

c4432c1

couple of changes for logging

4382929

enable workorder analysis

b4aac06

enable osl in workflow manager

9e73aa9

clean up

68be587

update github action and gitignore

061e57e

add toml library

6213809

wangcj05 added 16 commits August 15, 2025 11:53

fix deprecation warning

4b83b18

add visualization function

9b54c9d

further clean up

88794ed

add test for specific workflow

cd2e8ae

add tests fro workorder and operator shift log

0ac467f

add toml input for knowledge graph construction using neo4j

f460481

add other toml input for anomaly and similarity

00d6974

mv nlp inside workflow manager

bd00f8c

initial convert to use nlp group user input

2d0584f

simplify main file

14c18af

restructure workflow manager to allow multiple analysis

307efd5

few updates for nlp analysis

fd012f0

enable neo4j loading data

0778c61

testing is ok

2ffb7c5

add docstring

d55b946

remove unused input file

2c98bcf

wangcj05 requested a review from mandd August 20, 2025 19:36

mandd requested changes Sep 12, 2025

View reviewed changes

Merge branch 'main' into wangc/architecture

bb5345d

mandd approved these changes Sep 25, 2025

View reviewed changes

mandd merged commit d979218 into main Sep 25, 2025
4 checks passed

DACKAR Architecture Design #21

DACKAR Architecture Design #21

Uh oh!

Conversation

wangcj05 commented Aug 15, 2025 • edited by mandd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

Uh oh!

mandd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wangcj05 commented Sep 25, 2025

Uh oh!

mandd commented Sep 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wangcj05 commented Aug 15, 2025 •

edited by mandd

Loading