-
Notifications
You must be signed in to change notification settings - Fork 1
Mandd/kg improvs #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mandd/kg improvs #26
Conversation
| for node in constructionSchema['nodes'].keys(): | ||
| mapping = {value: key for key, value in constructionSchema['nodes'][node].items()} | ||
| data_renamed = data_temp.rename(columns=mapping) | ||
| self.py2neo.load_dataframe_for_nodes(df=data_renamed, labels=node, properties=list(mapping.values())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mandd FYI, I think there are some issues with the functions load_dataframe_for_nodes and load_dataframe_for_relations. I think they need some rework and test and they may not work properly at this point.
| node_properties = [{name = "date", type = "string", optional = false}, | ||
| {name = "ID", type = "string", optional = false}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why there are two entries here.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.