Remove Python 3.8 support, and add python 3.13 and numpy 2.0 support #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahGale
added
CI/CD
code improvement
This reverts commit 4156a20.
Collaborator
Author
|
Want to review this now @tjlaboss, so if everything passes tomorrow we can merge on Python day? |
Collaborator
Author
|
It looks like pytest-profile is incompatible with 3.13. I'm thinking of just uninstalling it for now as a work around |
Collaborator
|
Yeah, we can remove it from CI and just profile <=3.12 locally |
Collaborator
Author
|
We can still profile. Just do the profiling on <= 3.12 in CI. We don't need profiling to run the test suite in 3.13 |
tjlaboss
reviewed
Oct 7, 2024
Collaborator
tjlaboss
left a comment
tjlaboss
left a comment
There was a problem hiding this comment.
LGTM pending Python 3.13 CI
tjlaboss
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.
Fixes #201, fixes #457
Checklist