Skip to content

Fixed bug that was comparing string to listNodes #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 7, 2024
Merged

Fixed bug that was comparing string to listNodes #561

merged 11 commits into from
Oct 7, 2024

Conversation

@MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Oct 1, 2024 •
edited
Loading

Description

This bug is caused by a shortcut being in a fill. This is because it tries "(" in list_node.nodes'. Due to the shortcut there is a ListNode(shortcut) in this list which requires aeq` test.
This was fixed by

Fixes #552

Checklist

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@MicahGale MicahGale linked an issue Oct 1, 2024 that may be closed by this pull request
ListNode comparison is blocking contains for ListNode #552
Closed
@MicahGale MicahGale self-assigned this Oct 1, 2024
@MicahGale MicahGale added the bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". label Oct 1, 2024
@MicahGale MicahGale changed the title 552 listnode comparison is blocking contains for listnode Fixed bug that was comparing string to listNodes Oct 1, 2024
@MicahGale MicahGale requested a review from tjlaboss October 1, 2024 13:30
@MicahGale MicahGale marked this pull request as ready for review October 1, 2024 13:30
@MicahGale MicahGale force-pushed the 552-listnode-comparison-is-blocking-contains-for-listnode branch from 874af41 to a129b17 Compare October 1, 2024 14:09
@MicahGale MicahGale merged commit 1bd1c71 into develop Oct 7, 2024
15 checks passed
@MicahGale MicahGale deleted the 552-listnode-comparison-is-blocking-contains-for-listnode branch October 7, 2024 17:37
@MicahGale MicahGale mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels

bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error".

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ListNode comparison is blocking contains for ListNode

3 participants

@MicahGale @tjlaboss