Fixing bug when attempting to edit a cell geometry #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahGale
added
the
bugs
tjlaboss
approved these changes
Oct 7, 2024
Collaborator
tjlaboss
left a comment
tjlaboss
left a comment
There was a problem hiding this comment.
I like the helpful error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An error is raised when a cell geometry is edited without being fully initialized and linked to the corresponding surfaces. Rather than letting this happen instead an
IllegalStateis raised. This error is really most a @MicahGale problem, and shouldn't be typical user behavior.Fixes #558
Checklist