-
Notifications
You must be signed in to change notification settings - Fork 13
Make it Possible to have sparse fill matrices #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MicahGale
wants to merge
29
commits into
develop
Choose a base branch
from
601-uncaught-iterator-error-in-fill
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is paused while I figure out how to handle partial matrices. |
|
Ok this time it is ready @tjlaboss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugs
A deviation from expected behavior that does not reach the level of being reportable as an "Error".
low priority
parsers are hard
Examples of where MCNP syntax is complicated and should be simplified.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
This fixes a bug where sparse fill matrices can't be parsed. The MCNP manual does allow for fill sparsity in the multiple universe fill system at the end. This handles this case by padding the list with effective "jumps", and then defaulting those to universe
0
(per the manual).At first all the fill universe data was one long list. I was doing a lot of janky things to edit just the middle of the list, etc. I realized though: this is a small grammar. So I actually added a syntax tree that splits this into
indices
(the0:1
section for multi-universe),universes
, andtransform
. This greatly simplified the code and increased legibility.Fixes #601
General Checklist
black
version 25.Documentation Checklist
First-Time Contributor Checklist
pyproject.toml
if you wish to do so.Additional Notes for Reviewers
Ensure that:
📚 Documentation preview 📚: https://montepy--695.org.readthedocs.build/en/695/