Skip to content

Conversation

@MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Nov 4, 2025

Pull Request Checklist for MontePy

Description

Trying to find a physically realistic nuclide is not straight forward. So in the past hypothesis has come up with some wild nuclides, that broke MontePy's meta-state detection system, namely Bk-187. This updates the test suite to calculate the binding energy (using the semi-empirical mass formula) for heavier elements (> iron), and rule out nuclides with low binding energy per nuclide, and exclude them from the test suite. This was based on this curve.

Fixes #818


General Checklist

  • I have performed a self-review of my own code.
  • The code follows the standards outlined in the development documentation.
  • I have formatted my code with black version 25.
  • I have added tests that prove my fix is effective or that my feature works (if applicable).

LLM Disclosure

Were any large language models (LLM or "AI") used in to generate any of this code?

  • Yes
    • Model(s) used:
  • No

Documentation Checklist

  • I have documented all added classes and methods.
  • For infrastructure updates, I have updated the developer's guide.
  • For significant new features, I have added a section to the getting started guide.

First-Time Contributor Checklist

  • If this is your first contribution, add yourself to pyproject.toml if you wish to do so.

Additional Notes for Reviewers

Ensure that:

  • This PR fully addresses and resolves the referenced issue(s).
  • The submitted code is consistent with the merge checklist outlined here.
  • The PR covers all relevant aspects according to the development guidelines.
  • 100% coverage of the patch is achieved, or justification for a variance is given.

📚 Documentation preview 📚: https://montepy--851.org.readthedocs.build/en/851/

@MicahGale MicahGale linked an issue Nov 4, 2025 that may be closed by this pull request
@MicahGale MicahGale self-assigned this Nov 4, 2025
@MicahGale MicahGale added CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users. labels Nov 4, 2025
@MicahGale MicahGale marked this pull request as ready for review November 4, 2025 17:00
@MicahGale MicahGale requested a review from tjlaboss November 4, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hypothesis creates non-existant breaking nuclides

2 participants