Skip to content

Don't allow logging errors to cancel a job #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't allow logging errors to cancel a job #621

wants to merge 1 commit into from

Conversation

@loganharbour
Copy link
Member

@loganharbour loganharbour commented Jun 22, 2025

Closes #618

@loganharbour loganharbour requested a review from milljm July 9, 2025 01:47
milljm
milljm approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@milljm milljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, it was doing that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@milljm milljm milljm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't allow logging errors to kill jobs

2 participants

@loganharbour @milljm